fix: .undefined file extension when interacting with dir directly
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2024 13:21
|
|
|
Gamote
changed the title
undefined out file extension when interacting with dir directly.undefined file extension when interacting with dir directly
kdy1
approved these changes
Jan 28, 2024
|
Published as v0.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
v0.3.3ifdir.tsis called directly, like many consumers do, we would experience the.undefinedfile extension issue. (#287).This is because prior
v0.3.3the default extension was stored insidedir.ts. So even though we have the defaults inoptions.tsit will never reachdir.ts.I see it as breaking change so this PR creates a constant (
DEFAULT_OUT_FILE_EXTENSION) close to the options, that can also be used indir.ts.The changes were tested through manual and automated tests (
yarn test).